Skip to content

ci: enable bazel-diff #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 2 commits into from
Jun 20, 2026
Merged

ci: enable bazel-diff #3838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3159149
Enable bazel-diff in CI configs
rickeylev Jun 20, 2026
2f2fae6
Merge branch 'main' into enable-bazel-diff-ci
rickeylev Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ buildifier:
bazel: 7.x
skip_in_bazel_downstream_pipeline: "Bazel 7 required"
.reusable_config: &reusable_config
environment:
USE_BAZEL_DIFF: "1"
Comment thread
rickeylev marked this conversation as resolved.

@dougthor42 dougthor42 Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this env var used? Is it baked into .bazelci config outside of the rules_python repo or something?

I was trying to look up what exactly it would end up doing. I know about https://github.com/Tinder/bazel-diff but we don't have it as a bazel_dep.

@jvolkman jvolkman Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's here: https://github.com/bazelbuild/continuous-integration/blob/36dd157dc727d2787c4f8f515825e63bdb52e4be/buildkite/bazelci.py#L539

@dougthor42 dougthor42 Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

build_targets:
- "--"
- "..."
Expand Down