feat: restore flag aliases to Starlark-defined flags#3932
Open
gregestren wants to merge 2 commits into
Open
Conversation
Tested: ``` USE_BAZEL_VERSION=9.0.0 bazelisk build --nobuild //tests/py_zipapp:system_python_zipapp ERROR: Analysis of target '//tests/py_zipapp:system_python_zipapp' failed; build aborted: no such package '@@rules_python//python/config_settings': The repository '@@rules_python' could not be resolved: Repository '@@rules_python' is not defined ``` ``` USE_BAZEL_VERSION=9.2.0 bazelisk build --nobuild //tests/py_zipapp:system_python_zipapp INFO: Build completed successfully, 0 total actions ``` References: - bazel-contrib#3450 (comment) - bazel-contrib#3450 (comment)
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
Pull request overview
Restores flag_alias mappings in MODULE.bazel so legacy/native Python-related Bazel flags resolve to rules_python’s Starlark-defined flags again, addressing the Bazel 9.x regression discussed in #3450 and referenced issue comments.
Changes:
- Re-enable
flag_aliasforbuild_python_zip. - Re-enable
flag_aliasforincompatible_default_to_explicit_init_py. - Re-enable
flag_aliasforpython_pathandexperimental_python_import_all_repositories.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Any other tests I should check besides routine CI? |
rickeylev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was breaking rules_python CI with Bazel 9.0.0.
@aranguyen and I made some changes that we thought would resolve in 9.1.0 or 9.2.0.
The repro I tried on 9.0.0 now passes:
Tested:
References: