Do not percent-encode '+' in classpath-jar manifest Class-Path entries#522
Closed
mgalindo-sc wants to merge 1 commit into
Closed
Conversation
The java stub template packs over-long classpaths into a classpath jar whose manifest Class-Path entries percent-encode any character outside [-_.~/a-zA-Z0-9]. Bzlmod canonical repository names put '+' into every external-repo classpath entry, so those entries now contain "%2b" sequences. '+' is a valid URI path character and needs no encoding, and the "%2b" breaks consumers that pass classpath URLs through printf-style formatting: Robolectric's Logger.info() treats its message as a format string, so its native runtime loader throws MissingFormatArgumentException on "%2b" while logging the library URL, the load aborts, and every SQLite-backed android_local_test fails with UnsatisfiedLinkError on SQLiteConnectionNatives.nativeOpen. Add '+' to the allowed character class so it passes through literally.
Contributor
|
I'd suggest discussing this change with the rules_java folks first; that's where this repo's stub template is copied from. |
Contributor
Author
PR in |
Contributor
|
This made it into the upstream rules_java bazelbuild/rules_java#358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add '+' to the allowed character class so it passes through literally.
The java stub template packs over-long classpaths into a classpath jar whose manifest Class-Path entries percent-encode any character outside [-_.~/a-zA-Z0-9]. Bzlmod canonical repository names put '+' into every external-repo classpath entry, so those entries now contain "%2b" sequences. '+' is a valid URI path character and needs no encoding, and the "%2b" breaks consumers that pass classpath URLs through printf-style formatting