pick: answer on a mark that overhangs its tile - #44
Merged
Conversation
A symbol is drawn around its anchor and its mark overhangs the tile edge, but the feature lives in the tile that holds the anchor. The query replayed only the tile under the point, so a pick on the overhanging part of a buoy answered the water instead of the buoy — the mariner's click was on the mark they could plainly see. The pick now replays every neighbour whose edge stands within a mark's reach of the point (48 reference px, in tile units), the query point re-expressed in each neighbour's frame, on both the single-chart and the composed path. A dedupe keeps the once-per-feature contract: a feature near an edge is baked into both tiles' buffers and would answer twice. Emit before recording, so a full table cannot eat a hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A symbol is drawn around its anchor and its mark overhangs the tile edge, but the feature lives in the tile that holds the anchor. The query replayed only the tile under the point, so a pick on the overhanging part of a buoy didn't report the buoy.
The pick now replays every neighbor whose edge stands within a mark's reach of the point (48 reference px, in tile units), the query point re-expressed in each neighbor's frame, on both the single-chart and the composed path.