Update request-info to require Probot v7.2.0 - #40
Merged
Conversation
- Update package-lock as well
- Tests were breaking because Probot v6 was exporting a method called `createRobot` which no longer exists. This was replaced by the `Application` class which is now being used in the tests.
- The mock json files were using the deprecated `event` key which was raising warnings when running the tests. This was resolved by using the updated key `name`.
|
Thanks so much for opening your first PR here! |
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. |
hiimbex
reviewed
Oct 10, 2018
hiimbex
left a comment
hiimbex
left a comment
Member
There was a problem hiding this comment.
Looks great! Would you mind also including the same requested changes from behaviorbot/sentiment-bot#29 (review) ?
Contributor
Author
|
@hiimbex This PR is also ready for review again 👍 |
- New specs were still referencing `robot` after merging in the `master` branch to get my local branch up to date. They have been updated to `app` to get the tests to pass.
hiimbex
approved these changes
Oct 17, 2018
|
Congrats on merging your first pull request here! 🎉 How awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating request-info as per the Updating Probot issue in welcome opened by @hiimbex. 😄
This PR will
package.jsonto require Probot v7.2.0 or higher