Test with linux clang-23, and gcc-16 in docker#297
Open
ClausKlein wants to merge 11 commits into
Open
Conversation
ClausKlein
marked this pull request as draft
July 18, 2026 07:52
Collaborator
Author
|
my docker file to build clang-23: |
ClausKlein
commented
Jul 18, 2026
This seems to force linker errors with import std;
ClausKlein
force-pushed
the
feature/test-with-linux-clang-23
branch
from
July 21, 2026 18:04
5f1d878 to
105b8be
Compare
ClausKlein
commented
Jul 21, 2026
(and documenting the workaround) until LLVM fixes the underlying problem.
(for Clang only needed) Prevent Clang -Werror or fixed them too
ClausKlein
marked this pull request as ready for review
July 22, 2026 16:34
ClausKlein
commented
Jul 22, 2026
Comment on lines
+68
to
+72
| add_compile_options( | ||
| $ENV{CXXFLAGS} | ||
| -Wno-missing-braces | ||
| -Wno-unneeded-internal-declaration | ||
| ) |
ClausKlein
commented
Jul 22, 2026
| struct state; | ||
|
|
||
| auto operator()(::beman::execution::detail::counting_scope_base* ptr) const { | ||
| // TODO(CK): prevent -Wmissing-braces clang++ error! |
ClausKlein
commented
Jul 22, 2026
Comment on lines
+108
to
109
| // TODO(CK): prevent -Wunneeded-internal-declaration error! | ||
| friend auto operator==(const test_scheduler&, const test_scheduler&) noexcept -> bool = default; |
ClausKlein
commented
Jul 22, 2026
|
|
||
| if(NOT CMAKE_CXX_FLAGS MATCHES "-stdlib=libc\\+\\+") | ||
| string(APPEND CMAKE_CXX_FLAGS " -stdlib=libc++") | ||
| string(APPEND CMAKE_CXX_FLAGS " -stdlib=libc++ -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0") |
Collaborator
Author
There was a problem hiding this comment.
@ednolan this prevents the clang linker errors in Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not intended to be merged, only to show the current problems with
import std;see too: