Clean up address parse error display#17
Merged
Merged
Conversation
- Remove redundant crate::error!/printer.print duplication in exit node error handler; route through printer.error() for readline safety - Add Printer::error/warn/info methods that format via Output machinery, keeping prefix and colour consistent between REPL and headless output - Fix Level::Error display from bare `-` to `[-]` for visual consistency with [+], [!], [~] - Replace duplicate crate::info! + printer.print pairs in entry server loop with single printer.info()/printer.error() calls Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace ambiguous "(peer: {name})" label with "as {name}" in startup
messages. The node was referring to its own identity as "peer", which
reads as if it is describing a remote connection.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
maxholman
added a commit
that referenced
this pull request
Mar 15, 2026
- #23: debug-level TCP relay connect/close logs with byte counts on exit node - #25: PskFailTracker deduplicates PSK failure logs per source IP (x1, x2, x4…) - #27: log "PSK authentication configured" on startup when PSK is set - #17: startup banner shows CLI binary version + build timestamp/git hash + dirty flag - Remove double-warn on PSK failure (validate_handshake + caller) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up address parse error display
Scope
CLI address parsing and error display —
crates/cliOut of scope
Any changes to parsing logic or valid address formats
Why
When an invalid address is provided (e.g.
--connect attacker),the error appears twice — once as a bullet and once as
Error:. Shouldappear once, without duplication.