fix(default-flatpaks): remove check for fedora-third-party opt-out#516
Merged
Conversation
xynydev
approved these changes
Jan 26, 2026
xynydev
left a comment
xynydev
left a comment
Member
There was a problem hiding this comment.
The reasoning sounds solid here. Hope this is the case, as I'm approving the change :p
Sorry it took so long
Member
|
Why the f-- did copilot try to review this? |
Contributor
Author
|
Hi @fiftydinar, Could you please take a look at this PR when you have a moment? It has already been approved by @xynydev, but it looks like your review as a code owner is still needed to unblock the merge. Thanks for your time! |
fiftydinar
approved these changes
Jul 22, 2026
Member
|
Oh yeah, I could've just merged this too. Brain forgets things. Thanks for the ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies Fedora third-party repository opt-out in
system-flatpak-setupby removing the call to/usr/lib/fedora-third-party/fedora-third-party-opt-outand using/usr/bin/fedora-third-party disablewhen available.The opt-out helper is single-purpose: it flips the third-party status from unset to disabled and exists to allow a different pkexec configuration so an admin can opt out without authenticating on first run. This seems the best option if we
bootc switchfrom a fresh install, but if the third-party status has already been set, any call to this helper prints a message directing callers to/usr/bin/fedora-third-party disableand returns a non-zero exit code, which causes our setup flow to abort before the intended disable step can run.There may be a more sophisticated way to solve this, but relying directly on
/usr/bin/fedora-third-party disableremoves the redundant helper invocation, avoids the premature failure path, and ensures the disable action executes consistently on both first and subsequent runs.