Remove dead code and simplify adapter tests - #1070
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughS3フォロワーのリーダープロキシ転送と検証を更新し、Redisの互換用SET dedup設定、暗号化管理のkeystore注入、DynamoDB正規化、ストリーム補助APIを削除しました。DynamoDBのサイズ超過テストも統合しています。 ChangesS3フォロワープロキシ
Redis互換ゲート整理
互換APIと補助関数の削除
DynamoDBテスト統合
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Follower as S3フォロワー
participant Proxy as ReverseProxy
participant Leader as S3リーダー
Follower->>Proxy: リーダーへの転送を開始
Proxy->>Leader: Rewrite済みURL・RawQuery・Host・転送ヘッダー
Leader-->>Follower: 転送レスポンス
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://cdn.github.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up various unused fields, methods, and helpers across the codebase, including DynamoDB index unmarshaling, encryption admin keystore configurations, Redis standalone SET deduplication, and unused stream helpers. Additionally, it refactors S3 leader proxying to use the modern httputil.ReverseProxy with a Rewrite callback instead of the deprecated Director approach, and updates the corresponding tests. Feedback on the S3 proxy implementation notes that the manual assignment of the X-Forwarded-For header is redundant, as req.SetXForwarded() handles this automatically.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@codex review |
|
Review follow-up:
HEAD: ee9fea8 |
![chatgpt-codex-connector[bot]](https://cdn.github.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee9fea82a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Review follow-up for HEAD 14052b5:
Validation:
|
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Impact and risk
The removed symbols had no reachable callers in the complete program, including tests, on both macOS and Linux analysis. Active configuration options remain unchanged. The S3 proxy refactor preserves SigV4-sensitive request fields and adds explicit regression coverage.
Validation
golangci-lint run ./... --timeout=5mstaticcheck ./...go test -race ./adapter -run ^TestS3Server_ProxiesFollowerRequests$ -count=1go test ./adapter -run ^(TestS3Server_ProxiesFollowerRequests|TestDynamoDB_RequestBodyTooLarge)$ -count=1go list ./... | rg -v ^github.com/bootjp/elastickv/adapter$ | xargs go test -count=1The full
go test ./... -count=1run reached the adapter suite but was stopped after it made no progress for approximately four minutes; the targeted adapter tests above passed.Summary by CodeRabbit
バグ修正
ドキュメント
テスト