raft: add streaming multi-group soak evidence - #1127
Conversation
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Latest-head evidence for
The local full @codex review |
There was a problem hiding this comment.
Code Review
This pull request introduces a deterministic transport soak tool, updates Jepsen workloads to support multi-group streaming soak tests, and adds Prometheus metrics to track outbound stream opens, reconnects, messages, and snapshot activity. A critical issue was identified in the Jepsen database setup where server environment variables are silently ignored because start-daemon! does not support the :env key; wrapping the daemon startup with c/with-env was suggested to resolve this.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Latest-head review update for The high Jepsen environment finding was checked against the pinned @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da2f2c180e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Latest-head evidence for
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Review-loop stop recorded for |
Summary
Risk
The runtime change is limited to observational transport counters. Raft message routing, acknowledgements, quorum decisions, and fallback behavior are unchanged. The soak and verifier fail closed when required topology, delivery, reconnect, snapshot, or backpressure evidence is missing.
Test evidence
make lintgo test -race ./internal/raftengine/etcd/transportsoak ./internal/raftengine/etcd ./monitoring ./cmd/elastickv-raft-stream-soakgo run ./cmd/elastickv-raft-stream-soak -output docs/evidence/raft_streaming_multigroup_soak.jsongo run ./cmd/elastickv-raft-stream-soak -verify docs/evidence/raft_streaming_multigroup_soak.jsonbash -n scripts/run-jepsen-raft-streaming-multigroup-soak.sh scripts/verify-raft-streaming-multigroup-metrics.shshellcheck scripts/run-jepsen-raft-streaming-multigroup-soak.sh scripts/verify-raft-streaming-multigroup-metrics.shcd jepsen && lein test elastickv.cli-test elastickv.dynamodb-multi-table-workload-test(23 tests, 42 assertions)