Skip to content

support Python 3.14#8919

Merged
ThomasWaldmann merged 6 commits into
borgbackup:masterfrom
ThomasWaldmann:py314
Jun 12, 2025
Merged

support Python 3.14#8919
ThomasWaldmann merged 6 commits into
borgbackup:masterfrom
ThomasWaldmann:py314

Conversation

@ThomasWaldmann

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jun 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.04%. Comparing base (394cec6) to head (2924fc5).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8919   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files          77       77           
  Lines       13491    13491           
  Branches     1996     1996           
=======================================
  Hits        11069    11069           
  Misses       1757     1757           
  Partials      665      665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann

ThomasWaldmann commented Jun 12, 2025

Copy link
Copy Markdown
Member Author

Bug in Python 3.14b2?

  File "/home/runner/work/borg/borg/src/borg/archiver/create_cmd.py", line 472, in _rec_walk
    with OsOpen(
         ~~~~~~^
        path=path, parent_fd=parent_fd, name=name, flags=flags_dir, noatime=True, op="dir_open"
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ) as child_fd:
    ^
  File "/opt/hostedtoolcache/Python/3.14.0-beta.2/x64/lib/python3.14/contextlib.py", line 162, in __exit__
    self.gen.throw(value)
    ~~~~~~~~~~~~~~^^^^^^^
  File "/home/runner/work/borg/borg/src/borg/archive.py", line 254, in OsOpen
    yield fd
TypeError: _pystart_callback expected 2 arguments, got 3

https://github.com/borgbackup/borg/actions/runs/15610099353/job/43968754179#step:8:4934

@ThomasWaldmann
ThomasWaldmann force-pushed the py314 branch 2 times, most recently from cd0b0a3 to 47664ed Compare June 12, 2025 15:40
@ThomasWaldmann

Copy link
Copy Markdown
Member Author

Now only test_debug_profileis failing, likely due to a bug in stdlibcProfile.Profile`.

@ThomasWaldmann
ThomasWaldmann merged commit 7b9fe15 into borgbackup:master Jun 12, 2025
15 checks passed
@ThomasWaldmann
ThomasWaldmann deleted the py314 branch June 12, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant