Skip to content

test(compat): document why three goldens are byte-identical #81

Description

@phramz

Context

After PR #77's initial v2 capture, three of the eight committed goldens at test/compat/testdata/golden/v2/*.json are byte-identical (md5 `330d8a4c4d74ac3ecab485370a1e5ea5`):

  • `bare.json`
  • `single-ext.json`
  • `multi-ext.json`

This is consistent with v2's behavior on the GitHub-hosted ubuntu-24.04 image — redis and xdebug are already pre-installed, so adding them via the action's `extensions:` input doesn't change `php -m` output. But a future maintainer looking at the goldens will reasonably wonder if the capture workflow is broken.

Fix

Add a one-paragraph `README.md` under `test/compat/testdata/golden/v2/` (or extend the existing `test/compat/testdata/golden/README.md` once it's added per #77's spec) explaining the input/output convergence pattern.

Acceptance

  • `test/compat/testdata/golden/v2/README.md` exists and explains the byte-identical expectation
  • The text references which fixtures' inputs are non-distinguishing on the hosted-runner image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions