ci: warn on release PRs when GHCR bundles are not public#12
Merged
Conversation
The standalone update-major-tag workflow does not fire when release-please pushes the version tag, because workflows triggered by GITHUB_TOKEN do not trigger downstream workflows. Move the tag in the same workflow that created the release so the major tag stays in sync with each release.
Adds a check that runs only on release-please pull requests, derives the list of GHCR packages from bundles.lock, and anonymously verifies each manifest namespace is publicly pullable. Fails the check (with a job summary listing each non-public package and a deep link to its visibility settings page) so the maintainer can flip visibility before merging the release PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-release-pr.ymlruns on PRs whose head branch starts withrelease-please--, derives the GHCR package names frombundles.lock(php-core,php-ext-<name>,php-tool-<name>), and anonymously checks each via the GHCR token endpoint.Test plan
package-visibilityjob runs and reports per-package status in the job summary.if: startsWith(github.head_ref, 'release-please--')guard).