feat: install coverage driver when coverage input is set#14
Merged
Conversation
The coverage input (xdebug, pcov) was parsed but never acted upon, so PHPUnit runs with --coverage-* aborted with "No code coverage driver available" / "No tests executed!" unless the runner happened to have a driver in its system PHP. Auto-install the requested driver from the catalog and configure it: - coverage: xdebug -> installs xdebug with xdebug.mode=coverage - coverage: pcov -> installs pcov with pcov.enabled=1 - coverage: none -> unchanged (no driver installed) Plan.ApplyCoverage adds the driver to the effective extensions list so the existing resolve/fetch/compose pipeline handles it transparently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coverageinput was parsed but never applied. PHPUnit runs with--coverage-*aborted withNo code coverage driver available/No tests executed!unless the runner's system PHP happened to ship a driver.Plan.ApplyCoveragenow adds the requested driver to the effective extensions list so the existing resolve/fetch/compose pipeline installs and configures it from the catalog.coverage: xdebug→xdebug.mode=coverage;coverage: pcov→pcov.enabled=1;coverage: none(default) unchanged.Test plan
make check(gofmt, vet, golangci-lint, go test -race -cover, eslint, build)TestApplyCoveragecovers: none, empty, xdebug, pcov, already-present, empty extensionscoverage: pcovto a workflow consumingbuildrush/setup-php@v1and confirm--coverage-coberturaruns