fix: build and upload release assets from release-please workflow#15
Merged
Conversation
Standalone tag-triggered workflows (release-action, update-major-tag) never fired for release-please releases because tag pushes made with the default GITHUB_TOKEN do not trigger downstream workflows. This left v1.0.1 and v1.1.0 with no phpup-linux-amd64 asset, breaking `uses: buildrush/setup-php@v1` consumers whose action JS resolves the release tag and tries to download from `releases/download/<tag>/...`. Fold the build + upload steps (and the already-migrated major-tag move) into release-please.yml so they run in the same job that creates the release -- same pattern PR #10 used for the major-tag move. Delete the now-redundant release-action.yml and update-major-tag.yml. After this change no workflow triggers on `push: tags: ...`, closing the class of bug entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-action.yml,update-major-tag.yml) never fired for release-please releases: tag pushes made with the defaultGITHUB_TOKENdon't trigger downstream workflows. Result:v1.0.1andv1.1.0shipped with no assets, souses: buildrush/setup-php@v1consumers 404 when fetchingphpup-linux-amd64and end up on a fallback path without the newly-added coverage-driver support (manifesting asNo code coverage driver available/No tests executed!).release-please.ymlso they run in the same job that creates the release — same pattern PR fix: move floating major tag from release-please workflow #10 used for the major-tag move. Delete the now-redundantrelease-action.ymlandupdate-major-tag.yml.push: tags: ..., closing the class of bug entirely (no 3rd recurrence possible).Why this is safe for branch protection
The required status checks on
mainareci-lint gateandintegration-test gate, produced byci-lint.ymlandintegration-test.ymlwhich trigger onpull_request: branches: [main]. That path is unchanged — release-please PRs have been producing both gates (verified on PR #11 for v1.1.0).Follow-up
Existing
v1.0.1andv1.1.0releases have no assets and need backfilling out-of-band. Tracking separately.Test plan
phpup-linux-amd64,planner-linux-amd64, andsha256sums.txton the new release.v1floating tag still advances (unchanged from PR fix: move floating major tag from release-please workflow #10).ci-lint gateandintegration-test gategreen (branch protection satisfied).