[MIG] attachment_s3: Migration to 16.0

[jjscarafia]

No description provided.

[sbidoul]

Hi @jjscarafia. Would you mind merging this commit into this PR which adds the setup directory?

[adrienpeiffer]

Hi @jjscarafia Thanks for that. I prefer this way and it works perfectly

@gurneyalex @vrenaville Do you think it is possible to merge this ? We can continue after to improve the management of the stream

[vrenaville]

@jjscarafia @adrienpeiffer
I will merge it, I just need to figure out what's the issue with pylint travis error

[sbidoul]

@vrenaville please don't forget to pick up adhoc-dev#1

[sbidoul]

Hi @vrenaville. Any news here?

Note it should be reasonably easy to apply the oca addons repo template here. It should now have everything needed to be configured for any organization.

[vrenaville]

@adrienpeiffer

Could you please rebase, I have add your proposition in base_attachment, it's much more standard #427

We have spend time to switch to github actions, so rebase will fix your build

[jjscarafia]

@vrenaville rebase done!
thanks

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.05%. Comparing base (0d0ca60) to head (4a2c919).
⚠️ Report is 18 commits behind head on 16.0.

Additional details and impacted files

@@           Coverage Diff           @@
##             16.0     #401   +/-   ##
=======================================
  Coverage   36.05%   36.05%           
=======================================
  Files          33       33           
  Lines         760      760           
  Branches      106      106           
=======================================
  Hits          274      274           
  Misses        480      480           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[Firepoison]

Is there any reason this wasn't committed to 16 yet?

[nilshamerlinck]

Hi @Firepoison

• you might want to have look at fs_attachment module instead
• C2C is also moving towards oca/storage, see feat: remove unused modules #485 (comment)