[18.0][FIX] monitoring_log_requests: fix blacklist and status_code - #517
Open
dnplkndll wants to merge 1 commit into
Open
[18.0][FIX] monitoring_log_requests: fix blacklist and status_code#517dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
- Add /websocket to blacklist (Odoo 18 uses websockets for bus) - Fix response_status_code: hasattr checked request instead of response, and wrote to wrong key (status_code vs response_status_code) - Add default "" for PATH_INFO to avoid NoneType.startswith error
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three bugs in the 18.0 port of monitoring_log_requests.
Fixes
/websocketto blacklist (Odoo 18 uses websockets for bus notifications instead of longpolling)response_status_code:hasattrcheckedrequestinstead ofresponse, and wrote to wrong key name""forPATH_INFOto preventNoneType.startswitherror