address PR comments round 1 - #2
Merged
Merged
Conversation
carriganm95
commented
Apr 10, 2026
carriganm95
commented
Owner
- Added check in getValueOrListOf to ensure the number of planes is correct if a list is provided
- make getValueOrListOf a constant function, removed inline
- Removed StandardRecord and StandardRecordFlat from CMake file where unnecessary
There was a problem hiding this comment.
Pull request overview
This PR addresses prior review feedback by tightening configuration validation in GaussHitFinderSBN and cleaning up unnecessary link dependencies in the CAF RecoUtils library.
Changes:
- Add a size check when reading per-plane FHiCL sequences in
getValueOrListOf. - Update
getValueOrListOfto be aconstmember function (and remove the explicitinlinekeyword). - Remove unnecessary
sbnanaobj::StandardRecord*dependencies fromcaf_RecoUtils’s CMake link list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sbncode/HitFinder/GaussHitFinderSBN_module.cc |
Adds validation for per-plane parameter vectors read from FHiCL. |
sbncode/CAFMaker/RecoUtils/CMakeLists.txt |
Drops unused StandardRecord link dependencies for the RecoUtils library. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
79
to
86
| if (pset.is_key_to_sequence(key)) | ||
| auto vec = pset.get<std::vector<T>>(key); | ||
| if (vec.size() != N_PLANES) { | ||
| throw cet::exception("Configuration") | ||
| << "Parameter '" << key << "' has size " << vec.size() | ||
| << " but expected " << N_PLANES << " (number of planes)"; | ||
| } | ||
| return pset.get<std::vector<T>>(key); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.