Add Optional skipNpmrc input - #173
Closed
JP-Dhabolt wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: 2c90823 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This would benefit our use case with AWS CodeArtifact too. We have a And |
Author
|
@jameslnewell If you update your workflow that references this action to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of trying to use this action for a private Azure DevOps Artifact Feed (where the
.npmrcfile usesusernameand_passwordinstead of_authToken), I ran into the issue where the file was always modified by the action.This PR adds an optional input called
skipNpmrcwhich simply bypasses any checks, creation, or update of the.npmrcfile. Not including the new input continues to behave exactly as it does today.None of the code in the new
createOrUpdateNpmrcfunction was modified, just extracted into the function.While I am unblocked since I am running the action successfully now from the fork, I thought this might be generally useful if others have the same problem. If this is not in line with your vision of the action, please feel free to close. No hard feelings. 😄