Skip to content

Improve and speed up autocrypt/pgp gossipping with MDNs - #8481

Merged
hpk42 merged 3 commits into
mainfrom
hpk/mdn-refresh-key
Jul 27, 2026
Merged

Improve and speed up autocrypt/pgp gossipping with MDNs#8481
hpk42 merged 3 commits into
mainfrom
hpk/mdn-refresh-key

Conversation

@hpk42

@hpk42 hpk42 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor
  1. Contacts we only have read messages from (common when just lurking in group chats)
    now learn our current key and relay list through encrypted MDNs that contain an Autocrypt header
    that we can regard as a kind of an Autocrypt-Gossip: addr=<self> header.

  2. Group members stop re-gossipping keys that that their owner just distributed themselves.

  3. MDNs go to all authentic relays of a contact instead of just a single contact.get_addr()

the PR also speeds up tracking incoming autocrypt-gossip headers of large chats by doing 1 SQL commit instead of N commits for N autocrypt-gossip headers.

@hpk42 hpk42 changed the title Improve and speed up autocrypt/pgp gossipping through MDNs Improve and speed up autocrypt/pgp gossipping with MDNs Jul 25, 2026
Comment thread src/sql/migrations.rs Outdated
Comment thread src/mimefactory.rs Outdated
Comment thread src/mimefactory.rs
Comment thread src/mimeparser.rs Outdated
Comment thread src/mimeparser.rs Outdated
Comment thread src/mimefactory/mimefactory_tests.rs Outdated
@link2xt

link2xt commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

For reference, the issue with MDN being sent only to one address is reported at https://support.delta.chat/t/mdn-read-receipts-stopped-coming/5576

Comment thread src/sql/migrations.rs Outdated
@hpk42
hpk42 force-pushed the hpk/mdn-refresh-key branch from c3cf369 to 0100dd1 Compare July 26, 2026 09:43
Comment thread src/sql/migrations.rs Outdated
@hpk42
hpk42 force-pushed the hpk/mdn-refresh-key branch 2 times, most recently from 0a54bfd to f0f9045 Compare July 26, 2026 15:46

@j-g00da j-g00da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment thread src/mimefactory.rs Outdated
hpk42 added 3 commits July 27, 2026 21:36
- treat an Autocrypt header as a kind of Autocrypt-Gossip: addr=<self>
  letting it participate in the existing cooperative key gossipping mechanics.

- speed up processing of incoming autocrypt-gossip headers by using
  1 sql commit for N gossip headers instead of the current N commits.
@hpk42
hpk42 force-pushed the hpk/mdn-refresh-key branch from f0f9045 to da9a6f8 Compare July 27, 2026 19:36
@hpk42
hpk42 merged commit 00e1d00 into main Jul 27, 2026
30 checks passed
@hpk42
hpk42 deleted the hpk/mdn-refresh-key branch July 27, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants