Improve and speed up autocrypt/pgp gossipping with MDNs - #8481
Merged
Conversation
link2xt
reviewed
Jul 25, 2026
link2xt
reviewed
Jul 25, 2026
link2xt
reviewed
Jul 25, 2026
link2xt
reviewed
Jul 25, 2026
link2xt
reviewed
Jul 25, 2026
link2xt
reviewed
Jul 25, 2026
Collaborator
|
For reference, the issue with MDN being sent only to one address is reported at https://support.delta.chat/t/mdn-read-receipts-stopped-coming/5576 |
link2xt
reviewed
Jul 26, 2026
hpk42
force-pushed
the
hpk/mdn-refresh-key
branch
from
July 26, 2026 09:43
c3cf369 to
0100dd1
Compare
link2xt
reviewed
Jul 26, 2026
hpk42
force-pushed
the
hpk/mdn-refresh-key
branch
2 times, most recently
from
July 26, 2026 15:46
0a54bfd to
f0f9045
Compare
link2xt
reviewed
Jul 27, 2026
- treat an Autocrypt header as a kind of Autocrypt-Gossip: addr=<self> letting it participate in the existing cooperative key gossipping mechanics. - speed up processing of incoming autocrypt-gossip headers by using 1 sql commit for N gossip headers instead of the current N commits.
…r get_addr() returns.
hpk42
force-pushed
the
hpk/mdn-refresh-key
branch
from
July 27, 2026 19:36
f0f9045 to
da9a6f8
Compare
link2xt
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contacts we only have read messages from (common when just lurking in group chats)
now learn our current key and relay list through encrypted MDNs that contain an Autocrypt header
that we can regard as a kind of an
Autocrypt-Gossip: addr=<self>header.Group members stop re-gossipping keys that that their owner just distributed themselves.
MDNs go to all authentic relays of a contact instead of just a single
contact.get_addr()the PR also speeds up tracking incoming autocrypt-gossip headers of large chats by doing 1 SQL commit instead of N commits for N autocrypt-gossip headers.