resend broadcast reactions together with message - #8496
Open
r10s wants to merge 1 commit into
Open
Conversation
hpk42
approved these changes
Aug 1, 2026
hpk42
left a comment
hpk42
left a comment
Contributor
There was a problem hiding this comment.
lgtm apart from two comment nits :)
| count: usize, | ||
| } | ||
|
|
||
| /// Render one or more message's reactions as a JSON string, ready to be sent in `Broadcast-Reactions:` header. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Render one or more message's reactions as a JSON string, ready to be sent in `Broadcast-Reactions:` header. | |
| /// Renders one or more message's reactions as a JSON string, ready to be sent in `Broadcast-Reactions:` header. |
| if let Some(json) = broadcast_reactions::render_json(context, &[msg.id]).await? { | ||
| msg.param.set(Param::BroadcastReactions, json); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
i'd add a comment that even empty reactions will be Some here, so even rejoining members get reactions cleared as neccessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR resends reactions together with channel messages.
the PR merges into #8450 and is a separate PR to not complicate already ongoing reviews or tests
all in all, this was much simpler than expected :)