Version Packages#5
Merged
Merged
Conversation
github-actions
Bot
force-pushed
the
changeset-release/main
branch
from
November 16, 2024 20:26
a6e7c16 to
396c54c
Compare
coderdan
added a commit
that referenced
this pull request
Jul 8, 2026
…#5) offerStashConfig returned a truthy DEFAULT_CLIENT_PATH even when it created nothing, so installCommand's `if (clientPath)` guard scaffolded the encryption client anyway. Three related fixes, all on this one surface: - #2: return null when no config is created (declined / cancelled / existing), so the caller skips the client scaffold too. Declining now touches nothing. - #4: in 'offer' mode a non-interactive run no longer silently writes a config (+ client) into a bare project — those files import stash / @cipherstash/stack and would just re-defer the MODULE_NOT_FOUND crash to the next command. It returns null; the missing-config guidance points the user at `stash init`. ('ensure'/init still creates unconditionally; init installs the deps.) - #5: use the shared isCiEnv() (handles CI=1 / CI=TRUE) instead of the raw `process.env.CI !== 'true'`, matching the sibling resolveDatabaseUrl so the two steps classify the same environment consistently. Tests: offerStashConfig now asserts null + no write for the non-interactive offer and existing-config cases; a new e2e drives `eql install` with the URL from env (non-TTY) and asserts neither a config nor a client is written.
coderdan
added a commit
that referenced
this pull request
Jul 8, 2026
…#5) offerStashConfig returned a truthy DEFAULT_CLIENT_PATH even when it created nothing, so installCommand's `if (clientPath)` guard scaffolded the encryption client anyway. Three related fixes, all on this one surface: - #2: return null when no config is created (declined / cancelled / existing), so the caller skips the client scaffold too. Declining now touches nothing. - #4: in 'offer' mode a non-interactive run no longer silently writes a config (+ client) into a bare project — those files import stash / @cipherstash/stack and would just re-defer the MODULE_NOT_FOUND crash to the next command. It returns null; the missing-config guidance points the user at `stash init`. ('ensure'/init still creates unconditionally; init installs the deps.) - #5: use the shared isCiEnv() (handles CI=1 / CI=TRUE) instead of the raw `process.env.CI !== 'true'`, matching the sibling resolveDatabaseUrl so the two steps classify the same environment consistently. Tests: offerStashConfig now asserts null + no write for the non-interactive offer and existing-config cases; a new e2e drives `eql install` with the URL from env (non-TTY) and asserts neither a config nor a client is written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@cipherstash/jseql@2.0.0
Major Changes