Skip to content

fix(clerk-js): Update existing SignUp object on SignUpContinue OAuth #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LauraBeatris merged 1 commit into from
May 21, 2024
Merged

fix(clerk-js): Update existing SignUp object on SignUpContinue OAuth #3401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/loud-tables-rush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@clerk/clerk-js': patch
---

A bug was fixed to not override the existing sign-up state on the OAuth callback.

When continuing a sign-up flow with social connections, `@clerk/clerk-js` was creating a new `SignUpResource` object, instead of patching the existing one.

This was affecting Web3 sign-up flows, since the wallet ID was being overridden on the browser redirect.
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/components/SignUp/SignUpContinue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ function _SignUpContinue() {
<SignUpSocialButtons
enableOAuthProviders={showOauthProviders}
enableWeb3Providers={showWeb3Providers}
continueSignUp

@LauraBeatris LauraBeatris May 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javascript/packages/clerk-js/src/core/resources/SignUp.ts

Lines 207 to 208 in ff52e79

const authenticateFn = (args: SignUpCreateParams | SignUpUpdateParams) =>
continueSignUp && this.id ? this.update(args) : this.create(args);

Since continueSignUp wasn't being provided, then a new SignUp object was created on the redirect.

@LauraBeatris LauraBeatris May 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing other flows here and this could end up introducing side effects, so please let me know 🙇🏻

@panteliselef panteliselef May 19, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓Shouldn't the absence of continueSignUp create issues for the rest of oath providers ? Did we verify that those were failing as well, because if they were successful that would seem weird.

@LauraBeatris LauraBeatris May 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create issues for the rest of oath providers

Good point, I haven't verified yet - what are other flows that someone could fall on ContinueSignUp?

@panteliselef panteliselef May 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have verified (offline) that flows work as expected

/>
)}
<SignUpForm
Expand Down