Skip to content

Change the filename from lowercase 'version' to uppercase 'VERSION'.#2

Closed
dengwa wants to merge 1 commit into
cloudfoundry:masterfrom
HuaweiTech:hw-issue-3
Closed

Change the filename from lowercase 'version' to uppercase 'VERSION'.#2
dengwa wants to merge 1 commit into
cloudfoundry:masterfrom
HuaweiTech:hw-issue-3

Conversation

@dengwa

@dengwa dengwa commented Jul 30, 2014

Copy link
Copy Markdown

The lowercase 'version' causes a warning

cat: /home/ly/workspace/buildpack-python/buildpack-packager/lib/../../VERSION: No such file or directory

and the created online/offline package name with blank version, i.e. "python_buildpack-v.zip", the correct name should be "python_buildpack-v1.0.1.zip".

@cf-gitbot

Copy link
Copy Markdown

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/75944522.

@squeedee

squeedee commented Aug 6, 2014

Copy link
Copy Markdown
Contributor

Thanks for the PR!
We've done this already, in parallel, with far less finesse :D

@squeedee squeedee closed this Aug 6, 2014
davidbilik pushed a commit to davidbilik/python-buildpack that referenced this pull request Jul 29, 2016
use syntax highlighting in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants