Demo: assert HypervisorMaintenance owns the Evicting condition - #348
Draft
fwiesel wants to merge 1 commit into
Draft
Demo: assert HypervisorMaintenance owns the Evicting condition#348fwiesel wants to merge 1 commit into
fwiesel wants to merge 1 commit into
Conversation
Assert via managedFields that the status patch in hypervisor_maintenance_controller.go claims ownership of the Evicting condition entry under the HypervisorMaintenance field manager. This pins ownership at the write site so future refactors cannot silently drop the FieldOwner or move the write to a different controller without failing the test.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this branch will not change overall coverage
Coverage by fileChanged unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo-only: shows that the maintenance controller's status patch at
internal/controller/hypervisor_maintenance_controller.go:91correctly stampsFieldOwner=HypervisorMaintenanceon theEvictingcondition entry.The new test walks the hypervisor's
managedFields, locates the entry for thestatussubresource, and asserts that the manager owning thek:{"type":"Evicting"}key equalsHypervisorMaintenanceControllerName.Verified negative: temporarily changing the FieldOwner argument at that call site to
"WrongOwner"makes both spec instances (autoandmanualmaintenance modes) fail.Not intended for merge.