[POST]: post_type filter on index close #86 - #163
Merged
Conversation
Contributor
|
@snewcomer would you mind adding summary here to the description? |
joshsmith
force-pushed
the
post-type-filter
branch
from
August 31, 2016 04:40
07b3d19 to
b2e1967
Compare
Contributor
|
Completely missed the fact that we should be able to provide multiple post types in the filter. Not ready yet. |
Contributor
|
Should be good to go now, I changed the filter. Could use a review by someone else. |
| post_types = | ||
| json["data"] | ||
| |> Enum.map(fn(r) -> r["attributes"] end) | ||
| |> Enum.map(fn(atts) -> atts["post-type"] end) |
Contributor
There was a problem hiding this comment.
r and atts could be better named.
Contributor
|
@joshsmith Merging this, since you took a look, so I can focus on ember |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
post_typefiltering on the index route for the post controller.