Hide email from response for all but authenticated user - #213
Merged
Conversation
joshsmith
requested changes
Sep 15, 2016
joshsmith
left a comment
joshsmith
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good. Would just add some brief documentation stating what's going on since it's non-obvious at first glance.
| CodeCorps.UserPhoto.url({user.photo, user}, :thumb) | ||
| end | ||
|
|
||
| def email(user, %Plug.Conn{assigns: %{current_user: current_user}}) do |
Contributor
There was a problem hiding this comment.
I would add some def documentation of this.
begedin
force-pushed
the
194-hide-email-for-all-but-authed-user
branch
from
September 15, 2016 19:39
834a74e to
1a69fa5
Compare
Contributor
Author
|
@joshsmith Need another review for this. |
begedin
force-pushed
the
194-hide-email-for-all-but-authed-user
branch
from
September 15, 2016 19:41
1a69fa5 to
d81922c
Compare
joshsmith
approved these changes
Sep 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194
I implemented this at the view level.
We can override record attributes by defining functions of the same name as the attribute. This function then receives the record as the first parameter and the
connas the second, so it's simple to compare the user being serialised with thecurrent_userassign in theconn.Took me a while to figure out this is possible, though.