Add PostComment API - #82
Merged
Merged
Conversation
| create table(:comments) do | ||
| add :body, :text | ||
| add :markdown, :text | ||
| add :state, :string |
Contributor
There was a problem hiding this comment.
I would make all of these null: false.
npendery
force-pushed
the
np-add-comments-api
branch
from
August 19, 2016 23:41
78f9964 to
fb1f128
Compare
Contributor
|
Yes, I think even after seeing I'm still partial to calling this |
Contributor
|
I'll finish this up. |
joshsmith
force-pushed
the
np-add-comments-api
branch
from
August 21, 2016 18:17
ede270f to
57e77f8
Compare
npendery
force-pushed
the
np-add-comments-api
branch
2 times, most recently
from
August 21, 2016 20:32
4059dee to
efce9ca
Compare
joshsmith
force-pushed
the
np-add-comments-api
branch
from
August 21, 2016 22:57
143b82e to
b6193e3
Compare
joshsmith
force-pushed
the
np-add-comments-api
branch
from
August 21, 2016 22:58
b6193e3 to
ecb254e
Compare
|
Looks good to me. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28