Disallow activating donations until transfers are available

[rileytaylor]

Problem

Can donation goals be set if you can't take transfers?

[joshsmith]

Yes, this appears to be the case. {{donations/donation-progress}} renders right now if project.donationsActive is true. On the API this means:

Enum.any?(project.donation_goals) && project.stripe_connect_plan != nil

You can create a StripeConnectPlan regardless of whether the account can accept donations.

This should probably lead us to consider some behavioral changes:

• The project.donationsActive is fairly misleading right now (on the API side mostly).
• activateDonations in Ember is also fairly misleading and should probably be more explicit that this action is creating the StripeConnectPlan for the project.
• Could show the button to activate only when transfers can be accepted.

Anything else I'm not thinking of @begedin?

[begedin]

I feel that yes, changing the wording in the code might be clearer to the developers. Adding inline documentation would help to.

I would like to point out, though (even though that's probably been considered), that we should keep the user-faced wording abstract. The user doesn't really need to know about stripe plans and might actually be confused by such wording.

[begedin]

As for transfers and when to show and not to show the button, this was initially implemented when we didn't have the payments setup form, so it might make sense to change the conditions now. It might even make sense not to allow activating or editing donations at all until the account setup process has been completed.

[joshsmith]

I think we should allow setting up donations, but disallow activating them. Setting them up can still be done even if verification takes awhile.

[joshsmith]

This way a project can parallelize some work and not feel "stuck".

[joshsmith]

I believe this needs a task on the API side, too.

[begedin]

Created code-corps/code-corps-api#630 as a related issue.

On the ember side, the first step in making the process clearer is being done in #969 by simplifying and flattening the menus.

The second step is to add messages to the UI of donation goal and payment pages.

If payments are set up:

• On the donation goals page, allow activating donation goals
• The payments page should link to the donation goals page if the payments have been fully setup.

If not set up:

• On the donation goals page, link to the payments page to complete setup