Skip to content

Update ember-stripe-service to the latest version 🚀 - #1472

Closed
greenkeeper[bot] wants to merge 1 commit into
developfrom
greenkeeper/ember-stripe-service-7.0.0
Closed

Update ember-stripe-service to the latest version 🚀#1472
greenkeeper[bot] wants to merge 1 commit into
developfrom
greenkeeper/ember-stripe-service-7.0.0

Conversation

@greenkeeper

@greenkeeper greenkeeper Bot commented Oct 29, 2017

Copy link
Copy Markdown

Version 7.0.0 of ember-stripe-service was just published.

Dependency ember-stripe-service
Current Version 6.0.0
Type devDependency

The version 7.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of ember-stripe-service.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 6 commits.

  • d4777c3 7.0.0
  • 555c2da Merge pull request #59 from ryanto/lazy_load_stripe
  • c917f22 Add contributor
  • dc27b67 Add a test for logging when only setting the LOG_STRIPE_SERVICE env var
  • 5c70d22 spacing fix
  • af5b992 Lazy load stripe and code clean up

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@joshsmith

Copy link
Copy Markdown
Contributor

To fully implement this, we can set the configuration for Stripe to have lazyLoad: true and in the beforeModel hock of any router we need to implement Stripe, we can load the Stripe service.

We may want to consider a mixin for this to avoid duplication of code, but it also may be worth the explicitness.

Also, I'm not sure I remember precisely how the mock: true setting works, but this may be worth employing in tests.

We'll also need to run yarn install here.

@joshsmith joshsmith added this to the 💅 Donations polish milestone Oct 30, 2017
@joshsmith joshsmith closed this Nov 12, 2017
@joshsmith
joshsmith deleted the greenkeeper/ember-stripe-service-7.0.0 branch November 12, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant