Render donation goal related errors properly - #814
Merged
Conversation
joshsmith
approved these changes
Nov 30, 2016
Contributor
|
🙌 LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds field-based validation error rendering for the donation goals page.
Also adds displaying of other generic server-side errors as a friendly error message.
I also realised our
isValidationErrorhelper on theproject.donatepage was wrong in assuming our server payload would contain a title set toVALIDATION_ERROR. Instead, it is now checking if any of the errors in the payload contains asourceproperty.The helper has also been moved into a separate module, since it's now also being used on the
project.donationspage.References
Fixes #813