Skip to content

Add account status verification to donation goals page - #820

Merged
joshsmith merged 1 commit into
developfrom
816-add-verifying-account-status
Dec 2, 2016
Merged

Add account status verification to donation goals page#820
joshsmith merged 1 commit into
developfrom
816-add-verifying-account-status

Conversation

@begedin

@begedin begedin commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

What's in this PR?

This adds a button to the project.settings.donations route, labeled "Refresh status".

Clicking this button triggers a reload of the stripeConnectAccount record for the project's organization.

This button is only visible if there is already a stripeConnectAccount record for the current organization, and if the chargesEnabled property of that account is set to false.

The button is shown instead of the donation goal management UI (list and forms), so the user will not be able to add or edit donation goals, or create a plan for the project, until stripeConnectAccount.chargesEnabled value is true.

References

Fixes #816

@joshsmith joshsmith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need one thing changed here but otherwise good to merge.

<p>
{{#if canAdd}}
<button class="clear add" {{action add project}}>Add Goal</button>
<p><button class="clear add" {{action add project}}>Add Goal</button></p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to break HTML elements up onto multiple lines?

@joshsmith joshsmith added this to the Improve Donations milestone Dec 2, 2016
@begedin
begedin force-pushed the 816-add-verifying-account-status branch from e3fbba3 to ea92968 Compare December 2, 2016 08:28
@joshsmith
joshsmith merged commit 14a9c1f into develop Dec 2, 2016
@joshsmith
joshsmith deleted the 816-add-verifying-account-status branch December 2, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants