Fix card loading (WIP) - #821
Conversation
|
Various states: new card processing - show the form and “Processing…” button (action on form) The problem is with the bolded state right now. The way that we have it, we render two buttons in this state, one on |
|
which is the desired button to show? the button on |
begedin
left a comment
begedin
left a comment
There was a problem hiding this comment.
I think it looks good, so approving, but there's one comment that we might want to consider.
| projectTitle: null, | ||
| wasNewCard: true, | ||
|
|
||
| isNewCard: empty('card.id'), |
There was a problem hiding this comment.
Someone might wonder why this isn't simply alias(cad.isNew), not realizing it's because card might be null to begin with. Maybe a comment would help?
At least, that's my assumption here. Maybe card.isNew would actually work? Does init get called if the component is not rendered?
There was a problem hiding this comment.
@begedin this one is tricky because it's an ObjectProxy which has content: null if there is none. This was the least hacky way I could think to deal with this.
Should definitely comment, but would prefer a better fix.
I'm not super satisfied with my implementation over all, but hey: it works.
There was a problem hiding this comment.
Maybe add a request for a better fix in the comment. Maybe someone gets inspired.
There was a problem hiding this comment.
@begedin can you make an issue refing this PR for us to fix? And put under this milestone, I guess.
e8fd2a9 to
7fd5da0
Compare
3 participants
What's in this PR?
WIP