Make card brand icons use px instead of em - #848
Merged
Conversation
rileytaylor
approved these changes
Dec 12, 2016
rileytaylor
left a comment
rileytaylor
left a comment
Contributor
There was a problem hiding this comment.
This is how I would do it as well. Best to use pixels with pixels. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Minor change that uses
pxinstead ofemfor card brand icons since they are pixel-perfect. Makes sense here overem, IMO.line-heighton the neighboringpthen matches height for the icon.