Add birthdate select - #877
Merged
Merged
Conversation
rileytaylor
approved these changes
Dec 15, 2016
rileytaylor
left a comment
rileytaylor
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Definitely going to use that x-select component for the others. Are we going to build a more proper select for businessType or are we going to leave that open to interpretation by the user? That's my only question since that deletion is a little unrelated and I haven't seen anything specific about it.
Contributor
Author
|
The business type is not needed. |
joshsmith
force-pushed
the
add-birthdate-select
branch
from
December 15, 2016 17:49
72f0c74 to
df6d7c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Work in progress.
Adds a birth date selector component to encapsulate setting the user's birth date.