update state drop - #880
Merged
Merged
Conversation
rileytaylor
force-pushed
the
863-update-state-dropdown
branch
2 times, most recently
from
December 17, 2016 07:48
28c456d to
237fc12
Compare
joshsmith
requested changes
Dec 17, 2016
joshsmith
left a comment
joshsmith
left a comment
Contributor
There was a problem hiding this comment.
Some quick changes needed. Should be fast to do.
| export default Component.extend({ | ||
| classNames: ['select-state'], | ||
| stateOptions: [ | ||
| { name: 'Alabama', id: 'AL' }, |
Contributor
There was a problem hiding this comment.
I would note this article link in here for documentation: https://support.stripe.com/questions/can-i-use-stripe-if-my-business-is-based-in-an-outlying-territory-of-a-supported
| page.setContext(this); | ||
| }, | ||
| afterEach() { | ||
| page.setContext(this); |
Contributor
There was a problem hiding this comment.
This should be page.removeContext();. We may have this wrong in some other tests. Like country, it looks like. Can fix in this PR.
rileytaylor
force-pushed
the
863-update-state-dropdown
branch
from
December 17, 2016 08:07
237fc12 to
0fa8479
Compare
joshsmith
reviewed
Dec 17, 2016
| }, | ||
| afterEach() { | ||
| page.setContext(this); | ||
| page.removeContext(this); |
Contributor
There was a problem hiding this comment.
I believe this is just page.removeContext()
joshsmith
reviewed
Dec 17, 2016
| page.setContext(this); | ||
| }, | ||
| afterEach() { | ||
| page.removeContext(this); |
rileytaylor
force-pushed
the
863-update-state-dropdown
branch
from
December 17, 2016 08:13
0fa8479 to
f94d012
Compare
joshsmith
approved these changes
Dec 17, 2016
Contributor
|
@rileytaylor LGTM. Merge when passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This updates the state dropdown to include a list of states and their corresponding postal codes.
References
Fixes #863
Progress on: #853