Update funds recipents form - #894
Merged
Merged
Conversation
marineb
force-pushed
the
884-update-funds-recipient-form
branch
from
December 18, 2016 06:26
167c8a2 to
bf1baaf
Compare
Contributor
|
@marine this is just for accepting donations, not for paying. These are strict requirements under know your customer laws and Stripe's needs. |
Contributor
|
Good work so far. I'll take over for now, since I'm available, and it's high priority. |
Contributor
Author
|
Thank you @begedin. Happy to style the radio buttons later. Lmk! |
Contributor
|
This ought to be good to review. The form has all the fields and submits correctly based on recipient type. The two integration tests I wrote ensure that. There are minor details on how the radio buttons look (wasn't sure about correct margins/paddings), but overall, it follows the provided designs, I think. |
joshsmith
force-pushed
the
884-update-funds-recipient-form
branch
from
December 19, 2016 03:29
8901cd7 to
1b24f25
Compare
joshsmith
approved these changes
Dec 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
References
Fixes #884
Design https://cl.ly/2o3C0p1Y1H2T/o.