Skip to content

Update funds recipents form - #894

Merged
joshsmith merged 1 commit into
developfrom
884-update-funds-recipient-form
Dec 19, 2016
Merged

Update funds recipents form#894
joshsmith merged 1 commit into
developfrom
884-update-funds-recipient-form

Conversation

@marineb

@marineb marineb commented Dec 18, 2016

Copy link
Copy Markdown
Contributor

What's in this PR?

  • didn't complete the org / individual toggle at the top. I wasn't sure how to extend the target area of the radio button with ember
  • I know my class names and the general markup structure aren't great :(
  • suggested some language changes (not sure what the requirements are here, just thought i'd share some diff options)
  • in the address section, I was wondering if all these fields are required for cc processing? (or could you have only the zipcode instead?)

References

Fixes #884
Design https://cl.ly/2o3C0p1Y1H2T/o.

@marineb
marineb force-pushed the 884-update-funds-recipient-form branch from 167c8a2 to bf1baaf Compare December 18, 2016 06:26
@joshsmith

Copy link
Copy Markdown
Contributor

@marine this is just for accepting donations, not for paying. These are strict requirements under know your customer laws and Stripe's needs.

@begedin begedin self-assigned this Dec 18, 2016
@begedin

begedin commented Dec 18, 2016

Copy link
Copy Markdown
Contributor

Good work so far. I'll take over for now, since I'm available, and it's high priority.

@marineb

marineb commented Dec 18, 2016

Copy link
Copy Markdown
Contributor Author

Thank you @begedin. Happy to style the radio buttons later. Lmk!

@begedin

begedin commented Dec 18, 2016

Copy link
Copy Markdown
Contributor

This ought to be good to review. The form has all the fields and submits correctly based on recipient type. The two integration tests I wrote ensure that.

There are minor details on how the radio buttons look (wasn't sure about correct margins/paddings), but overall, it follows the provided designs, I think.

@begedin begedin added this to the Launch Donations milestone Dec 18, 2016
@joshsmith
joshsmith merged commit 49d1ad3 into develop Dec 19, 2016
@joshsmith
joshsmith deleted the 884-update-funds-recipient-form branch December 19, 2016 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants