[WIP] payments/funds-recipient/personal-id-number component - #895
Closed
pixelhandler wants to merge 8 commits into
Closed
[WIP] payments/funds-recipient/personal-id-number component#895pixelhandler wants to merge 8 commits into
pixelhandler wants to merge 8 commits into
Conversation
Contributor
Author
|
This is only work in progress, will squash later when closer to complete |
Contributor
Author
|
There is more work still to be done, I think the logic isn't right for showing the verifying message, prolly needs to be there with a disabled submit button. I'm TDD'ing so that will be the next step. I pushed up a copy of my fork/branch upstream as well: https://github.com/code-corps/code-corps-ember/tree/886_payments/funds-recipient/personal-id-number_component |
Contributor
|
@pixelhandler This is the last bit of the puzzle, really, feature-wise, so I'll take over and wrap up today. Good work so far. |
Contributor
Author
|
@begedin ok thanks! |
Contributor
|
Think this was superseded by #906. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
payments/funds-recipient/personal-id-numbercomponentReferences
Progress on: #886