Skip to content

Fix issues with accounts - #920

Merged
joshsmith merged 1 commit into
developfrom
fix-issues-with-accounts
Jan 2, 2017
Merged

Fix issues with accounts#920
joshsmith merged 1 commit into
developfrom
fix-issues-with-accounts

Conversation

@joshsmith

Copy link
Copy Markdown
Contributor

What's in this PR?

WIP on matching up models with API.

@joshsmith joshsmith added this to the Launch Donations milestone Dec 30, 2016
@joshsmith

Copy link
Copy Markdown
Contributor Author

The bank-account component displays a bankAccountRoutingNumber and bankAccountLast4 that the API's StripeConnectAccount does not appear to track. This might possibly be in the external_account's information, but no such relationship exists in the API.

We'll need to identify whether this is something that needs corrected on the API side.

@joshsmith

Copy link
Copy Markdown
Contributor Author

Appears that errors are not cleared when an identity document, for example, is uploaded with an error but then is uploaded successfully later.

begedin
begedin previously requested changes Jan 1, 2017

@begedin begedin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things, but otherwise looks good.

.catch(() => this._wrapError(ACCOUNT_UPDATE_ERROR));
},

_creatPersonalIdNumberToken(personalIdNumber) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...how did this work?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open an issue for an acceptance test that steps through the whole thing?


{{payments/funds-recipient
isBusy=isBusy
onlegalEntityPersonalIdNumberSubmitted=(action onlegalEntityPersonalIdNumberSubmitted)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onlegal -> onLegal, if we wanna follow the convention of other actions

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, yep. Typo.

@begedin begedin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to go

Add the rest of the attributes we need

Make default numbers null

Update funds recipient details form

Update fields

Update Mirage config for testing

Update icons

Update to use Stripe PII token

Fix details form
@joshsmith
joshsmith force-pushed the fix-issues-with-accounts branch from 9f7f7ba to fc568a1 Compare January 2, 2017 09:12
@joshsmith
joshsmith merged commit ca2b647 into develop Jan 2, 2017
@joshsmith
joshsmith deleted the fix-issues-with-accounts branch January 2, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants