Setup github actions ci and docker ci - #5
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Jared-Krajewski
requested changes
Jul 8, 2026
Jared-Krajewski
left a comment
Jared-Krajewski
left a comment
Contributor
There was a problem hiding this comment.
A couple small things commented on the files. Thanks for getting this going.
Comment on lines
+11
to
+14
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| node_version: [24.x] |
Contributor
There was a problem hiding this comment.
I don't think anything here uses this node version and the os is otherwise isolated so we should be able to run this without the matrix and just runs-on: to ubuntu-latest.
this could reduce a little build overhead.
Contributor
There was a problem hiding this comment.
Comment on lines
+13
to
+16
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| runs-on: ${{ matrix.os }} |
Comment on lines
+25
to
+28
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| runs-on: ${{ matrix.os }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Resolves #1
Implements GitHub actions with parallel builds for the application and the docker build on PRs and merges.