Skip to content

docs(CONTRIBUTING): add section on testing - #3629

Merged
jsjoeio merged 1 commit into
mainfrom
jsjoeio/docs-testing
Jun 18, 2021
Merged

docs(CONTRIBUTING): add section on testing#3629
jsjoeio merged 1 commit into
mainfrom
jsjoeio/docs-testing

Conversation

@jsjoeio

@jsjoeio jsjoeio commented Jun 17, 2021

Copy link
Copy Markdown
Contributor

Checklist

  • updated CHANGELOG.md

@jsjoeio jsjoeio added this to the 3.11.0 milestone Jun 17, 2021
@jsjoeio jsjoeio added chore Related to maintenance or clean up testing Anything related to testing labels Jun 17, 2021
@jsjoeio jsjoeio self-assigned this Jun 17, 2021
@jsjoeio
jsjoeio force-pushed the jsjoeio/docs-testing branch from d93f7ff to d6bc68a Compare June 17, 2021 18:44
@codecov

codecov Bot commented Jun 17, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3629 (787d8d5) into main (5f7e9b7) will not change coverage.
The diff coverage is n/a.

❗ Current head 787d8d5 differs from pull request most recent head d9bb1a3. Consider uploading reports for the commit d9bb1a3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3629   +/-   ##
=======================================
  Coverage   60.67%   60.67%           
=======================================
  Files          35       35           
  Lines        1790     1790           
  Branches      404      404           
=======================================
  Hits         1086     1086           
  Misses        562      562           
  Partials      142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7e9b7...d9bb1a3. Read the comment docs.

@jsjoeio jsjoeio added the docs Documentation related label Jun 17, 2021
@jsjoeio
jsjoeio marked this pull request as ready for review June 17, 2021 18:48
@jsjoeio
jsjoeio requested a review from a team as a code owner June 17, 2021 18:48

@jawnsy jawnsy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!! 🔥 🔥 🔥

I love this, great pointers to help new contributors navigate the codebase and understand how things work

Comment thread docs/CONTRIBUTING.md Outdated
Comment thread docs/CONTRIBUTING.md Outdated
@janiversen

Copy link
Copy Markdown
Contributor

I am strongly in favor of of the 3 test levels, but I miss a definition of the definition and objective of each level. E.g. integration testing could be seen as the interface to to VScode.

@jsjoeio

jsjoeio commented Jun 17, 2021

Copy link
Copy Markdown
Contributor Author

but I miss a definition of the definition and objective of each level. E.g. integration testing could be seen as the interface to to VScode

Great feedback! I think I should clarify this a bit more on what we mean by each.

@jsjoeio
jsjoeio force-pushed the jsjoeio/docs-testing branch from 787d8d5 to 5dd9e6f Compare June 17, 2021 23:20
Comment thread docs/CONTRIBUTING.md Outdated
@jsjoeio
jsjoeio force-pushed the jsjoeio/docs-testing branch from 5dd9e6f to d9bb1a3 Compare June 17, 2021 23:25

@janiversen janiversen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsjoeio

jsjoeio commented Jun 18, 2021

Copy link
Copy Markdown
Contributor Author

Sweet! Thanks for the reviews @janiversen @jawnsy - going to merge

@jsjoeio
jsjoeio merged commit a51836f into main Jun 18, 2021
@jsjoeio
jsjoeio deleted the jsjoeio/docs-testing branch June 18, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Related to maintenance or clean up docs Documentation related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants