Skip to content

Update Code to 1.76.1 - #6070

Merged
code-asher merged 4 commits into
coder:mainfrom
code-asher:vscode-1.76.1
Mar 14, 2023
Merged

Update Code to 1.76.1#6070
code-asher merged 4 commits into
coder:mainfrom
code-asher:vscode-1.76.1

Conversation

@code-asher

@code-asher code-asher commented Mar 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  • worker-src already contains blob so we can avoid patching that.
  • localeService moved.
  • Remaining changes were just line changes.
  • Make language extensions installable again.
  • Remove broken "install in browser" for language packs.
  • Replace new locale import.

Closes #6050

@code-asher
Update Code to 1.76.1
8889059 
- worker-src already contains blob so we can avoid patching that.
- localeService moved.
- Remaining changes were just line changes.
@code-asher
Make language extensions installable again
e0f1417 
Still might want to look into making the native language support work
but for now it seems better not to break backwards compatibility since
the native implementation is quite different.
@benz0li

benz0li commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

@code-asher I will continue to deploy release candidates to https://coder.jupyter.b-data.ch, test them manually and give feedback.

@code-asher

code-asher commented Mar 14, 2023

Copy link
Copy Markdown
Member Author

Thank you! I think this is about ready to go, I just need to confirm the display language still works.

@code-asher
Avoid "install in browser" for language packs
afb22a4 
It will not work.
@code-asher
Import correct locale service
c44b57b 
I believe before the contributions imported this but now we have to do
it here.
@code-asher
code-asher marked this pull request as ready for review March 14, 2023 20:00
@code-asher
code-asher requested a review from a team as a code owner March 14, 2023 20:00
@code-asher
code-asher merged commit f9cc079 into coder:main Mar 14, 2023
@code-asher
code-asher deleted the vscode-1.76.1 branch March 14, 2023 20:03
@benz0li

benz0li commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Unable to build an image for v4.11.0-rc.1 with current extensions because of EclipseFdn/open-vsx.org#1684.

@benz0li

benz0li commented Mar 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

code-server-4.11.0-rc.1-linux-amd64.tar.gz from Release v4.11.0-rc.1 is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools).

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • webview

Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@2023.3.100
  • ms-python.python@2023.4.0

Terminal is still not rendered properly in Safari because of xtermjs/xterm.js#4120.
ℹ️ Workaround: "terminal.integrated.gpuAcceleration": "off"

@benz0li benz0li mentioned this pull request Mar 15, 2023
Closed
@benz0li

benz0li commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

@code-asher xtermjs/xterm.js#4120 is resolved now: xtermjs/xterm.js#4438.

Now it is just a matter of time until the fixed version is released, and updated there.

@code-asher

code-asher commented Mar 16, 2023

Copy link
Copy Markdown
Member Author

Awesome news!!

@benz0li

benz0li commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Regarding #6070 (comment):

[...] that fix is coming in 1.78 with this PR microsoft/vscode#178443.

– microsoft/vscode#177754 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat]: Upgrade Vscode to 1.76

2 participants

@code-asher @benz0li