feat: implement repo-mode#290
Merged
Merged
Conversation
mafredri
force-pushed
the
mafredri/repo-mode
branch
3 times, most recently
from
July 30, 2024 18:04
0acb5f6 to
5d4e5ca
Compare
johnstcn
reviewed
Jul 31, 2024
johnstcn
reviewed
Jul 31, 2024
johnstcn
reviewed
Jul 31, 2024
johnstcn
reviewed
Jul 31, 2024
johnstcn
reviewed
Jul 31, 2024
mafredri
force-pushed
the
mafredri/repo-mode
branch
from
August 1, 2024 13:23
5d4e5ca to
54a037e
Compare
mafredri
marked this pull request as ready for review
August 1, 2024 13:29
Member
Author
|
Rebased on main and amended PR feedback, ready for round 2. |
johnstcn
approved these changes
Aug 1, 2024
| return sb.String() | ||
| } | ||
|
|
||
| func (o *Options) CABundle() ([]byte, error) { |
Member
There was a problem hiding this comment.
I like this approach of hanging it off Options!
| t.Run("OK", func(t *testing.T) { | ||
| // 2024/08/01 13:22:08 unsupported capability: shallow | ||
| // clone "http://127.0.0.1:41499": unexpected client error: unexpected requesting "http://127.0.0.1:41499/git-upload-pack" status code: 500 | ||
| t.Skip("The gittest server doesn't support shallow cloning, skip for now...") |
johnstcn
pushed a commit
that referenced
this pull request
Aug 5, 2024
(cherry picked from commit 9073748)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218