Skip to content

feat(namespaces): add values schema - #1172

Open
voidus wants to merge 2 commits into
community-tooling:mainfrom
voidus:namespaces-schema
Open

feat(namespaces): add values schema#1172
voidus wants to merge 2 commits into
community-tooling:mainfrom
voidus:namespaces-schema

Conversation

@voidus

@voidus voidus commented May 9, 2026

Copy link
Copy Markdown

Heya,

I spent more time than I'd like to admit debugging and ultimately found out my values shape was wrong, so I thought I'd propose this change.

Version bumped since some values that worked before will now fail to validate, not sure if that aligns with your plans.
I also added a version of this without the tests if you'd prefer to merge this without them: #1173

@voidus
voidus requested a review from a team as a code owner May 9, 2026 15:01
@voidus voidus changed the title Namespaces schema feat(namespaces): add values schema May 9, 2026

@morremeyer morremeyer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition, thank you!

Thinking of the testing as also a good one, but I think we can even simplify that:

The CI already runs helm lint with the chart-testing tool, so all the tests for valid files can be moved to a *-values.yaml in charts/namespaces/ci.

I'm inclined to say that we don't necessarily need tests for invalid values, since the positive testing for valid values should cover most error cases easily. This would have the benefit that we'd be reusing the already existing workflows and we'd have one less script to maintain.

What do you think, @voidus?

@voidus

voidus commented Jun 29, 2026

Copy link
Copy Markdown
Author

I'll trust your judgement regarding the testing, I don't have enough experience to say how useful/annoying this will be during maintenance etc, but I guess the schema is unlikely to change anyways.

I added it because I wanted invalid configs to be flagged, so I added a test that shows me it actually does. But that doesn't mean they need to end up in the codebase long-term.

@morremeyer

Copy link
Copy Markdown
Member

Then I'd like to move the valid test files to the *-values.yaml naming in the ci directory, and the invalid files and the script can be removed.

That has the best tradeoff between maintenance effort and improved validation in my eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants