Fix 7 Google ADK examples that crash with SpawnSafetyError - #449
Merged
Conversation
Tools were defined as functions nested inside main(), which are never picklable under the SDK's default spawn start method. Hoisting them to module scope makes them importable by qualified name, matching every other example and satisfying probe_spawn_safety.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
bradyyie
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
poetry run ruff format && poetry run ruff check --fixto fixany format violations.
Changes in this PR
examples/agents/adk/14_callbacks.py-20_blog_writer.py(7 files) defined tool functions asclosures nested inside
main()— raisesSpawnSafetyErrorat registration, sincespawncan't pickle a function with qualname
main.<locals>.fn.defs to module level, matching every other example. No behavior change.multiprocessinglimitation, not an SDK or ADK bug —docs/WORKER.mdstatesthe same rule for
@worker_taskworkers.Issue #443
Alternatives considered
cloudpickle, orforkinstead ofspawn) — rejected,forkis unsafeon macOS (native-framework
SIGSEGV), which is whyspawnis the default.