Add "connect list" command and HTTP library infra - #2
Merged
Conversation
…or filtering connectors - this returns all, not just connect or per acct)
Cody A. Ray (codyaray)
requested review from
a team and
Travis Jeffery (travisjeffery)
May 5, 2018 16:38
Joshua Buss (chicagobuss)
approved these changes
May 7, 2018
Joshua Buss (chicagobuss)
left a comment
There was a problem hiding this comment.
awesome, great work!
| ErrMalformedToken = fmt.Errorf("malformed") | ||
| ) | ||
|
|
||
| // TODO: reuse corev1.Error from cc-structs |
Contributor
There was a problem hiding this comment.
+1 on reusing corev1
Contributor
|
👍 |
Cody A. Ray (codyaray)
added a commit
that referenced
this pull request
Apr 10, 2019
Cody A. Ray (codyaray)
added a commit
that referenced
this pull request
Apr 10, 2019
Prathibha Muralidharan (Prathibha-m)
added a commit
that referenced
this pull request
Sep 4, 2019
# This is the 1st commit message: Add subject commands # This is the commit message #2: Docs Unhide SR make deps
Prathibha Muralidharan (Prathibha-m)
added a commit
that referenced
this pull request
Sep 12, 2019
# This is the 1st commit message: Add subject commands # This is the commit message #2: Docs Unhide SR make deps
Prathibha Muralidharan (Prathibha-m)
added a commit
that referenced
this pull request
Sep 12, 2019
* Add --resource-id flag for create api key Pass AccountID from environment to create API key Mark current context API key in list of API keys Revert changes to API key delete Remove extra import Pass account ID to retrieve SR correctly update docs description Error handling and Cleanup fmt Add parameter for flag in GetKafkaConfig Address comments Remove unnecessary err check Modify integration test lint Locl commit Clean up Remove unit test (temp) Fix tests lint Modify resource scoped commands Add unit test Cleanup Integration test Clean fix WIP WIP Integration test clean wip Fix IT Clean up Fix fixture i nit Error test case Fixture spacing Remove ID check address comments Rebase on master Address comments Mock tests Improve unit test validation * Unhide SR nits Hide SR * Fix lint errors from Schema Registry * Cluster command updates * # This is a combination of 2 commits. # This is the 1st commit message: Add subject commands # This is the commit message #2: Docs Unhide SR make deps * More schema tests * WIP integration test Typo * minor:import order * address comments Address comments Update comment Mark geo flag required * Add logger * make fmt * Add CLIName replacement to docs * Error checks * create variables for reuse * rebase on master fmt Fmt
Brian Strauch (brianstrauch)
pushed a commit
that referenced
this pull request
May 31, 2023
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@confluentinc/caas
This PR adds the first end-to-end CLI command. It lists all the connectors in an account.
The core is a new HTTP package for our API.
HTTP Library Details:
client.Connect.List)Related changes:
confluent logincalls/api/meand adds user/account info to config fileHere's example CLI output from various scenarios: