Fix lint and CLI Integration Test errors from PR#258

[Prathibha Muralidharan (Prathibha-m)]

No description provided.

[Cyrus Vafadari (cyrusv)]

Hm should probably just be excluding as few as possible here

[Prathibha Muralidharan (Prathibha-m)]

I've excluded commands which don't use names/ID's (which is pretty much all of them)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@173f34d). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #273   +/-   ##
=========================================
  Coverage          ?   43.05%           
=========================================
  Files             ?       63           
  Lines             ?     4775           
  Branches          ?        0           
=========================================
  Hits              ?     2056           
  Misses            ?     2457           
  Partials          ?      262

Impacted Files	Coverage Δ
internal/cmd/schema-registry/command.go	70.16% <100%> (ø)
internal/cmd/schema-registry/command_subject.go	86.04% <100%> (ø)
internal/cmd/schema-registry/command_schema.go	53.04% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173f34d...2dc23fd. Read the comment docs.

[Cody A. Ray (codyaray)]

I think we need to step back and review the DevX here. It's inconsistent with the rest of the CLI.

[Cody A. Ray (codyaray)]

these are actual english words. why do they need to be added here?

[Cody A. Ray (codyaray)]

is this "only applies to..." still accurate?

[Prathibha Muralidharan (Prathibha-m)]

As per the 1-pager doc, that's what it says. But I'll check again!

[Prathibha Muralidharan (Prathibha-m)]

Will change it. Thanks for catching that!

[Cody A. Ray (codyaray)]

this is a very large blanket exclude. this already tests all the other "describe" commands (since that's a standard verb). I'm not sure about "enable" but it sounds pretty standard and shouldn't be wholeheartedly excluded like this.

(Both describe and enable refer to a single resource, right? That's why this exclusion doesn't make so much since, like "list" which doesn't refer to a single resource)

[Prathibha Muralidharan (Prathibha-m)]

I see your point. Would it then be a better idea to simply have linter.ExcludeCommandContains("schema-registry"), since schema-registry commands do not have a name or id passed in

[Cody A. Ray (codyaray)]

I don't think I was around to review the original PRs, but these don't seem to all fit with expected grammar for the CLI:
schema-registry <resource--noun> <standard verb: create/describe/update/delete/etc>

I would expect it to be more like this to fit with the rest of the CLI:

schema-registry cluster enable

schema-registry cluster describe
# describe should include the mode and compatibility level for the cluster

schema-registry cluster update --mode=READWRITE

schema-registry cluster update --compatibility=BACKWARD

schema-registry subject list
schema-registry subject describe subjectname
schema-registry subject update subjectname --mode=READWRITE
schema-registry subject update subjectname --compatibility=BACKWARD