Use shared protobufs from cc-structs where available - #3
Merged
Conversation
Cody A. Ray (codyaray)
requested review from
a team,
Joshua Buss (chicagobuss) and
Travis Jeffery (travisjeffery)
May 8, 2018 03:24
Contributor
There was a problem hiding this comment.
can we switch from sling to https://github.com/h2non/gentleman/? it'd be nice to have middleware support. we could've changed the response decoder and any other custom handling of the request/response via middleware. i don't think sling adds enough on net/http to make it worth it.
| return nil | ||
| } | ||
|
|
||
| func ConvertAPIError(err error) error { |
Contributor
There was a problem hiding this comment.
we can refactor this later and have it so we only have to define the errors in one place and then users can marshal the relevant message (human vs. system)
Travis Jeffery (travisjeffery)
approved these changes
May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@confluentinc/caas
I updated Sling to support custom decoders so we can decode the JSON protobuf messages. Here's the upstream PR. Until they merge it, I'm just using my branch.
Other bits: