Specifies goreleaser dependency for building from source - #444
Specifies goreleaser dependency for building from source#444Raja Shravan (rajashravan) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Raja Shravan (@rajashravan) you need to run make deps to install all dependencies, including goreleaser.
https://github.com/confluentinc/cli/blob/master/Makefile#L32
This is consistent with the developer UX for all of our cloud projects, fwiw. See https://github.com/confluentinc/cc-mk-include/#confluent-cloud-makefile-includes for details (tho CLI doesn't actually use cc-mk-include, we kept consistent with the targets for the most part)
Did you try make deps and it didn't install goreleaser? then maybe there's something inconsistent between the CLI devs go setup and yours. did you follow the Laptop Setup Guide for go? https://github.com/confluentinc/cc-documentation/blob/master/Operations/Laptop%20Setup.md
Yep, I ran |
|
It would be quite cool to get to the bottom of why goreleaser isn't being properly installed via make deps. Happy to help with bug-hunting. If we really can't get to the bottom of it, then I'd be ok merging, but this sounds like a bug with our make deps step so ideally we can fix it : ) |
044a07d to
b4658ed
Compare
|
Closed in favor of #571 -- though we still need to get to the bottom of this 😞 |

When I first tried building from source, I got an error when running
make buildbecause I didn't havegoreleaser. Updating the docs so the next person won't run into the same problem 😄