Skip to content

Specifies goreleaser dependency for building from source - #444

Closed
Raja Shravan (rajashravan) wants to merge 1 commit into
confluentinc:masterfrom
rajashravan:patch-1
Closed

Specifies goreleaser dependency for building from source#444
Raja Shravan (rajashravan) wants to merge 1 commit into
confluentinc:masterfrom
rajashravan:patch-1

Conversation

@rajashravan

Copy link
Copy Markdown

When I first tried building from source, I got an error when running make build because I didn't have goreleaser. Updating the docs so the next person won't run into the same problem 😄

@rajashravan
Raja Shravan (rajashravan) requested a review from a team as a code owner April 13, 2020 19:30

@codyaray Cody A. Ray (codyaray) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raja Shravan (@rajashravan) you need to run make deps to install all dependencies, including goreleaser.

https://github.com/confluentinc/cli/blob/master/Makefile#L32

This is consistent with the developer UX for all of our cloud projects, fwiw. See https://github.com/confluentinc/cc-mk-include/#confluent-cloud-makefile-includes for details (tho CLI doesn't actually use cc-mk-include, we kept consistent with the targets for the most part)

Did you try make deps and it didn't install goreleaser? then maybe there's something inconsistent between the CLI devs go setup and yours. did you follow the Laptop Setup Guide for go? https://github.com/confluentinc/cc-documentation/blob/master/Operations/Laptop%20Setup.md

@rajashravan

Copy link
Copy Markdown
Author

Did you try make deps and it didn't install goreleaser? then maybe there's something inconsistent between the CLI devs go setup and yours. did you follow the Laptop Setup Guide for go? https://github.com/confluentinc/cc-documentation/blob/master/Operations/Laptop%20Setup.md

Yep, I ran make deps and goreleaser was not installed. I never did that setup guide you linked before (only did the regular developer setup) because I don't work with CCloud - but not sure why that would prevent goreleaser from being installed. From the SC, it looks like make deps is skipping goreleaser for some reason:
image

@DABH

Copy link
Copy Markdown
Contributor

It would be quite cool to get to the bottom of why goreleaser isn't being properly installed via make deps. Happy to help with bug-hunting. If we really can't get to the bottom of it, then I'd be ok merging, but this sounds like a bug with our make deps step so ideally we can fix it : )

@DABH

Copy link
Copy Markdown
Contributor

Closed in favor of #571 -- though we still need to get to the bottom of this 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants