Add admin-managed OAuth sign-in flow - #1303
Open
Zetazzz wants to merge 32 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
pyramation
reviewed
Jun 23, 2026
| * GET /app-settings-auth | ||
| * Get current auth settings | ||
| */ | ||
| router.get('/app-settings-auth', async (req: Request, res: Response) => { |
Contributor
There was a problem hiding this comment.
why are we making REST routes for things the user can query for via our APIs?
pyramation
reviewed
Jun 23, 2026
| ip.scopes, | ||
| ip.pkce_enabled | ||
| FROM ${providersTable} ip | ||
| LEFT JOIN "constructive_store_private"."platform_secrets" secrets |
Contributor
There was a problem hiding this comment.
this is hardcoding a schema... probably not the right path here, either.
pyramation
reviewed
Jun 23, 2026
| // ─── SQL ──────────────────────────────────────────────────────────────────── | ||
|
|
||
| const USER_AUTH_MODULE_SQL = ` | ||
| SELECT |
Contributor
There was a problem hiding this comment.
this is the right solution, because it queries for the schema
Zetazzz
force-pushed
the
feat/oauth-reorg
branch
from
July 28, 2026 14:52
f0b3069 to
d0ad568
Compare
This comment has been minimized.
This comment has been minimized.
Zetazzz
force-pushed
the
feat/oauth-reorg
branch
from
July 30, 2026 23:33
c46d4c0 to
cc660c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@constructive-io/oauthwith reusable signed state handling and provider/client support used by the server flow.Behavior
Follow-ups
Testing
CI=true pnpm install --frozen-lockfilepnpm --dir packages/express-context exec jest --runInBand— 4 suites / 16 tests passedpnpm --dir graphql/server-test test— 8 suites / 139 tests passedf0b3069f56ae79b03ab1142e407744a5a639d7ae— 36/36 jobs passed: https://github.com/constructive-io/constructive/actions/runs/30234467094